Skip to content

Core functionality#1

Open
Julian-W98 wants to merge 19 commits intomainfrom
core_functionality
Open

Core functionality#1
Julian-W98 wants to merge 19 commits intomainfrom
core_functionality

Conversation

@Julian-W98
Copy link
Copy Markdown
Collaborator

@Julian-W98 Julian-W98 commented Apr 8, 2026

Add Core functionality

@Julian-W98 Julian-W98 self-assigned this Apr 8, 2026
@alethomas alethomas marked this pull request as ready for review April 9, 2026 12:15
Julian-W98 and others added 2 commits April 16, 2026 05:26
Remove hard coded conda environment from workflow_dispatcher.py
Comment thread README.md Outdated
Comment thread workflow_dispatcher.py

eval "$(/opt/mambaforge/bin/conda shell.bash hook)"
cd {workflow_path}
conda activate /projects/envs/conda/jzander/envs/snakemake_9_slurm
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a better way than hard coded Conda environments?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a ToDo

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Point.
Ich könnte als spalte zu den "conda_env_path" zu den workflows/*.csv hinzufügen. Damit könnten wir dann auch easy eigene envs für bestimmte workflows benutzen.

Allerdings ist das ja nur das Env, dass den Workflow initial anstößt. Daher sollte es überall gleich sein.
Alternativ würde ich es hard gecoded lassen, es aber als Konstante definieren und diese in der README beschreiben.

Was findest Du besser? Hat beides Vor und Nachteile.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ich würde mir morgen noch mal gedanken machen, ob es da vielleicht ne elegante lösung gibt. was hältst zu von einem Snakemake workflow als wrapper? 😜

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich plädiere für möglichst wenig Snakemake :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants